-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: fix ipv6 extension header parsing error #24309
bpf: fix ipv6 extension header parsing error #24309
Conversation
5c36213
to
e46b859
Compare
36666d8
to
630d7b4
Compare
630d7b4
to
9172bb3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9172bb3
to
61f95b0
Compare
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thank you for the additions to the tests and packet generator. I have one "little" thing we might want to look into
rebase is done, pls test |
5c81392
to
878dfaa
Compare
Please help to submit the test, I have made some simple adjustments on the test case. thx |
878dfaa
to
acef02a
Compare
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coccicheck complains about
file ./tests/pktgen.h: variable ctx on line 181 should be declared constant
9b9bbb4
to
1190862
Compare
fixed coccicheck and rebased |
Please back out the recent change to |
The ipv6_hdrlen function incorrectly sets the length of the extension header during parsing, causing cilum to obtain the wrong next header and resulting in packet loss. This issue will affect the parsing of IPv6 packets that carry both the "auth" and other extension headers, such as `ipv6/auth/hopbyhop/tcp`. Fixes: 1ce3c7f ("bpf: Skip over IPv6 extension headers") Fixes: cilium#24187 Signed-off-by: chenyuezhou <zcy.chenyue.zhou@gmail.com>
1190862
to
48d564d
Compare
Revert the modifications to proxy.h. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/test |
The ipv6_hdrlen function incorrectly sets the length of the extension header
during parsing, causing cilum to obtain the wrong next header and resulting
in packet loss.
This issue will affect the parsing of IPv6 packets that carry both the "auth"
and other extension headers, such as
ipv6/auth/hopbyhop/tcp
.Fixes: 1ce3c7f ("bpf: Skip over IPv6 extension headers")
Fixes: #24187
Signed-off-by: chenyuezhou zcy.chenyue.zhou@gmail.com