Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't orphan CEPs when node IP changes. #26281

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Don't orphan CEPs when node IP changes. #26281

merged 1 commit into from
Jun 26, 2023

Conversation

bprashanth
Copy link
Contributor

@bprashanth bprashanth commented Jun 15, 2023 •
edited
Loading

See #26279 for context.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #26279

Handles nodeIP changes when CEPs are checkpointed to tmpfs and the nodeIP changes across a reboot.

@bprashanth bprashanth requested a review from a team as a code owner June 15, 2023 23:35
@bprashanth bprashanth requested a review from christarazi June 15, 2023 23:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 15, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 15, 2023
@bprashanth bprashanth mentioned this pull request Jun 15, 2023
Closed
2 tasks
@bprashanth bprashanth force-pushed the pr/cep_nodeip branch 3 times, most recently from e66b4d0 to cd3c1d2 Compare June 19, 2023 16:20
@ti-mo ti-mo marked this pull request as draft June 20, 2023 13:03
@bprashanth
Copy link
Contributor Author

@aojea and/or @tommyp1ckles if you could do a first pass I'll rebase and fix unittests. Removing WIP from title based on conversation in #26279

@bprashanth bprashanth changed the title [WIP] Don't orphan CEPs when node IP changes. Don't orphan CEPs when node IP changes. Jun 20, 2023
@aojea
Copy link
Contributor

aojea commented Jun 21, 2023

@joestringer @christarazi this is a pretty contained and small change that fix a bug we are hitting it in production, can you assign a reviewer?

@joestringer joestringer added release-note/bug This PR fixes an issue in a previous release of Cilium. affects/v1.12 This issue affects v1.12 branch needs-backport/1.13 affects/v1.13 This issue affects v1.13 branch labels Jun 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 21, 2023
@joestringer
Copy link
Member

@aojea is this ready for review? It's marked as draft. It looks like Chris is already assigned to review when it's ready for review.

@aojea
Copy link
Contributor

aojea commented Jun 21, 2023

@aojea is this ready for review? It's marked as draft. It looks like Chris is already assigned to review when it's ready for review.

upps sorry, didn't notice , @bprashanth ^^^

@bprashanth
Copy link
Contributor Author

@joestringer @christarazi it's ready for review. I removed "wip" from the title a while back, did i miss something else indicating the draft status?

@bprashanth bprashanth marked this pull request as ready for review June 22, 2023 02:26
@bprashanth bprashanth force-pushed the pr/cep_nodeip branch 2 times, most recently from 30ffd46 to 8d5cfa6 Compare June 22, 2023 06:15
@bprashanth
Copy link
Contributor Author

Ah apologies, I think I just had to click the button that said "this is not a draft".
PATL.

@julianwiedmann
Copy link
Member

It's been a while - I'll go ahead and drop the needs-backport for v1.13. Please speak up if anyone still wants to tackle the backport.

skmatti pushed a commit to skmatti/cilium that referenced this pull request Jul 24, 2024
@bprashanth @yasz24
Don't orphan CEPs when node IP changes.
9e0e286 
This commit prevents a soft deadlock in the cilium agent by making it
check the pod's hostIP instead of the CEP's node IP.

Fixes: cilium#26279
Upstream-PR: cilium#26281

NB: this was not directly CP'd from OSS as it requires a few fairly large stacked commits to include the unittest libs at OSS HEAD. Instead the unittests in this pr were re-written to work with existing libs in GKE HEAD, and minimize the diff with OSS.

Change-Id: I4196a074b45fb88429226ba9b78b450a85c02f3b
Signed-off-by: Prashanth.B <beeps@google.com>
Reviewed-on: https://gke-internal-review.googlesource.com/c/third_party/cilium/+/744842
Reviewed-by: Akhil Velagapudi <avelagap@google.com>
Unit-Verified: Prow_Bot_V2 <425329972751-compute@developer.gserviceaccount.com>
Reviewed-on: https://gke-internal-review.googlesource.com/c/third_party/cilium/+/787754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@tommyp1ckles tommyp1ckles tommyp1ckles left review comments

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch area/daemon Impacts operation of the Cilium daemon. backport/author The backport will be carried out by the author of the PR. kind/bug This is a bug in the Cilium logic. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
8 participants
@bprashanth @aojea @joestringer @ldelossa @julianwiedmann @christarazi @tommyp1ckles @tklauser