Read FQDNRejectResponseCode from config #27362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
ayuspin
force-pushed
the
pr/read-fqdnrejectresponsecode-from-config
branch
from
2f5ac26 to
9f60b6b
Compare
ayuspin
force-pushed
the
pr/read-fqdnrejectresponsecode-from-config
branch
from
9f60b6b to
f143f0b
Compare
ti-mo
added
release-note/bug
|
/test |
|
@ayuspin You'll need to rebase to pick up the Go version bump needed for CI to pass. |
ti-mo
removed
the
dont-merge/needs-release-note-label
ayuspin
force-pushed
the
pr/read-fqdnrejectresponsecode-from-config
branch
from
f143f0b to
349b326
Compare
|
@ti-mo done |
|
It looks like you unfortunately picked a commit to base on main where the branch was broken. I'll click the rebase button to get this unblocked. |
Currently dnsProxy.dnsRejectResponseCode helm value is ignored because FQDNRejectResponseCode is not populated from viper Signed-off-by: Andrii Iuspin <yuspin@gmail.com>
joestringer
force-pushed
the
pr/read-fqdnrejectresponsecode-from-config
branch
from
349b326 to
8084fb1
Compare
|
/test |
christarazi
added
area/fqdn
pippolo84
added
the
backport-pending/1.14
pippolo84
removed
the
needs-backport/1.14
pippolo84
added a commit
to pippolo84/cilium
that referenced
this pull request
Aug 29, 2023
Commit 87518a3 ("Read FQDNRejectResponseCode from config") fixed the FQDNRejectResponseCode option handling, adding the missing code to read the value from the ConfigMap. Since the usage of StringVar does not correctly handle that case by itself, using it is pointless. This commit changes it to use String as we already do for every other string agent option. Relates: cilium#27362 Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Aug 30, 2023
Commit 87518a3 ("Read FQDNRejectResponseCode from config") fixed the FQDNRejectResponseCode option handling, adding the missing code to read the value from the ConfigMap. Since the usage of StringVar does not correctly handle that case by itself, using it is pointless. This commit changes it to use String as we already do for every other string agent option. Relates: #27362 Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
michi-covalent
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dnsProxy.dnsRejectResponseCode helm value is ignored because FQDNRejectResponseCode is not populated from viper