Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRI-O get script location #28738

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix CRI-O get script location #28738

merged 1 commit into from
Oct 24, 2023

Conversation

saschagrunert
Copy link
Contributor

@saschagrunert saschagrunert commented Oct 23, 2023 •
edited
Loading

The script has been moved to another repository, which is now fixed.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
None

@saschagrunert
Fix CRI-O get script location
5878553 
The script has been moved to another repository, which is now fixed.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert requested a review from a team as a code owner October 23, 2023 11:44
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 23, 2023
sayboras
sayboras approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM ✔️

@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Oct 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 23, 2023
@sayboras
Copy link
Member

Just a note that recently vagrant scripts are not well maintained in favor of kind clusters, so you might have some more issue here and there.

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 23, 2023
@dylandreimerink dylandreimerink merged commit 6913352 into cilium:main Oct 24, 2023
@saschagrunert saschagrunert deleted the cri-o-script branch October 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @sayboras @aditighag @dylandreimerink