Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update versions and parameters for XDP Acceleration on AKS #29091

Merged
merged 2 commits into from
Nov 17, 2023
Merged

docs: update versions and parameters for XDP Acceleration on AKS #29091

merged 2 commits into from
Nov 17, 2023

Conversation

jshr-w
Copy link
Contributor

@jshr-w jshr-w commented Nov 9, 2023 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Through testing with AKS, I determined that networking with XDP acceleration does not work correctly with the Mellanox ConnectX-3 NIC on Azure. This has also been cross-referenced as a known issue in the NVidia documentation (ref: 1550266). This PR updates to documentation to be clearer about this.
There are also some version and parameter inaccuracies for setting up a cluster with AKS that are corrected in this PR.

Fixes: #29065, #27289

@jshr-w jshr-w requested review from a team as code owners November 9, 2023 18:04
@jshr-w jshr-w requested review from ysksuzuki and qmonnet November 9, 2023 18:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 9, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 9, 2023
@jshr-w jshr-w changed the title docs: clarify Mellanox NICs that support XDP acceleration docs: update versions and parameters for XDP Acceleration on AKS Nov 10, 2023
@tamilmani1989 tamilmani1989 mentioned this pull request Nov 10, 2023
Closed
8 tasks
qmonnet
qmonnet requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please find some comments inline below.

Documentation/network/kubernetes/kubeproxy-free.rst Show resolved Hide resolved
Documentation/network/kubernetes/kubeproxy-free.rst Show resolved Hide resolved
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Nov 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 14, 2023
@jshr-w
correct NIC versions for XDP acceleration
6aa113d 
Mellanox Connect-X 3 NIC does not support XDP acceleration. Refer issue
1550266 here
	https://docs.nvidia.com/networking/display/mlnxofedv494170/known+issues.

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w
update docs for AKS versions
ec0d7e1 
AKS currently only supports snat mode.

Signed-off-by: jshr-w <shjayaraman@microsoft.com>
@jshr-w jshr-w force-pushed the docs/mellanoxcxver branch from f257615 to ec0d7e1 Compare November 15, 2023 20:18
@jshr-w
Copy link
Contributor Author

jshr-w commented Nov 15, 2023

@qmonnet Thanks for the feedback! I've made the requested changes.

@jshr-w jshr-w requested a review from qmonnet November 15, 2023 20:20
qmonnet
qmonnet approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@qmonnet
Copy link
Member

qmonnet commented Nov 16, 2023

/test

@tamilmani1989 tamilmani1989 mentioned this pull request Nov 16, 2023
Closed
@julianwiedmann julianwiedmann added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Nov 17, 2023
@julianwiedmann
Copy link
Member

Reviews are in, CI is green.

@julianwiedmann julianwiedmann merged commit 346a92e into cilium:main Nov 17, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@ysksuzuki ysksuzuki Awaiting requested review from ysksuzuki ysksuzuki is a code owner automatically assigned from cilium/sig-lb

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mellanox ConnectX-3 fails to work with XDP Acceleration
3 participants
@jshr-w @qmonnet @julianwiedmann