Fix helm chart incompatible types for comparison

[lou-lan]

Please ensure your pull request adheres to the following guidelines:

• For first time contributors, read Submitting a pull request
• All code is covered by unit and/or runtime tests where feasible.
• All commits contain a well written commit description including a title,
  description and a Fixes: #XXX line if the commit addresses a particular
  GitHub issue.
• If your commit description contains a Fixes: <commit-id> tag, then
  please add the commit author[s] as reviewer[s] to this issue.
• All commits are signed off. See the section Developer’s Certificate of Origin
• Provide a title or release-note blurb suitable for the release notes.
• Are you a user of Cilium? Please add yourself to the Users doc
• Thanks for contributing!

Fixes: #32024

Fix helm chart incompatible types for comparison

[maintainer-s-little-helper]

Commit 16f2c97 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 16f2c97 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[lou-lan]

Commit 16f2c97 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

I am already add Signed-off-by: xxx in my commit msg.

[gandro]

Thanks!

[gandro]

Actually, I believe (ne (quote $kubeProxyReplacement) "strict") will now always be true. Would toString work instead of quote?

[lou-lan]

Actually, I believe (ne (quote $kubeProxyReplacement) "strict") will now always be true. Would toString work instead of quote?

I am change to toString.

set kubeProxyReplacement to false and waitForKubeProxy to true

$ helm template cilium-release ./cilium-1.15.4.tgz \
--namespace kube-system     \
--set routingMode=native     \
--set ipv4NativeRoutingCIDR="172.16.25.134/24"     \
--set kubeProxyReplacement="false"     \
--set loadBalancer.mode=dsr     \
--set loadBalancer.dsrDispatch=opt     \
--set k8sServiceHost=172.16.25.134     \
--set k8sServicePort=6443 \
--set waitForKubeProxy=true | grep wait-for-kube-proxy

      - name: wait-for-kube-proxy
        terminationMessagePolicy: FallbackToLogsOnError # wait-for-kube-proxy

set kubeProxyReplacement to true and without waitForKubeProxy

helm template cilium-release ./cilium-1.15.4.tgz \
--namespace kube-system     \
--set routingMode=native     \
--set ipv4NativeRoutingCIDR="172.16.25.134/24"     \
--set kubeProxyReplacement="true"     \
--set loadBalancer.mode=dsr     \
--set loadBalancer.dsrDispatch=opt     \
--set k8sServiceHost=172.16.25.134     \
--set k8sServicePort=6443  | grep 'wait-for-kube-proxy'

          mountPath: /var/run/cilium # wait-for-kube-proxy

[gandro]

/test