makefile: check for $(CILIUM_CLI) dependency #32424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit executing any target that invoked
$(CILIUM_CLI)
silently failed (as of$?
==0
), e.g.kind-install-cilium
.This commit adds
check_deps
target in the main Makefile, and adds it as a target dep for all targets using$(CILIUM_CLI)
.See for instance:
Issue
No issue, but I can create one if necessary.
kubectl
and other deps are invoked in foreground, so they fail as expected. I could add them tocheck_deps
though, to have cleaner messages. Please advise.Release notes
Not sure if worth. Please advise.