Add Cilium Community Values #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
qmonnet
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Looks good, thank you!
Some formatting nitpicks: I'd recommend wrapping your text (on lines of about 80 characters) and commit description (usually around 72 characters, because it's no fun if we use the same value everywhere). I'd also recommend against curly quotes (’, likely generated by Google Docs), it's easier to stick to straight quotes for text manipulation/grepping. But none of this is blocking in my opinion.
I'd like to mention that this was discussed in the Committer's (private) channel, that several Committers manifested their approval, none raised any objection.
The values document lays out how Cilium works together as a project. For people new to the project, it should guide them as the best way to engage with the project (for example jumping in to solve their issues rather than waiting for it to be assigned to them) and for existing contributors it should help guide choices when ways of working need to be decided upon (for example should we implement this in eBPF) Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
xmulligan
force-pushed
the
add-values-doc
branch
from
7aecd8b to
c8c5560
Compare
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
joestringer
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values document lays out how Cilium works together as a project. For people new to the project, it should guide them as the best way to engage with the project (for example jumping in to solve their issues rather than waiting for it to be assigned to them) and for existing contributors it should help guide choices when ways of working need to be decided upon (for example should we implement this in eBPF)