Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub edit link on every page #1393

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fix GitHub edit link on every page #1393

merged 1 commit into from
Mar 26, 2024

Conversation

remram44
Copy link
Contributor

master branch was renamed to main, update mkdocs.yml to match.

The link in the top-right corner of every page is currently 404, example: https://github.com/cilium/ebpf/edit/master/docs/ebpf/guides/getting-started.md

master branch was renamed to main, update mkdocs.yml to match.

Signed-off-by: Remi Rampin <remi@rampin.org>
@remram44 remram44 requested a review from a team as a code owner March 24, 2024 17:34
@remram44
Copy link
Contributor Author

Contribution feedback: I am required to sign-off commits, but there is no explanation anywhere on what I'm signing:

GitHub screenshot

There's a helpful link to this page that states:

Before signing off on a commit, you should ensure that your commit is in compliance with the rules and licensing governing the repository you're committing to. The repository may use a sign off agreement, such as the Developer Certificate of Origin from the Linux Foundation.

However there is no information about this in your CONTRIBUTING guide. If you expect that people are signing documents you never presented to them, you should know that is not how signing works, and your whole process is probably legally moot.

@lmb
Copy link
Collaborator

lmb commented Mar 26, 2024

Thanks for your feedback. You're right that we should mention that we indeed need you to adhere to the developer certificate of origin: https://developercertificate.org/ It's not about signing a document but signalling that you have read and understood the DCO.

Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmb
Copy link
Collaborator

lmb commented Mar 26, 2024

See #1396

@lmb lmb merged commit 2528370 into cilium:main Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants