Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ICMP info on Service Map and Flows Table #351

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

kimstacy
Copy link
Member

This change adds ICMP information to the Service Map and Flows Table.

It also improves the Destination Port and Protocol section in the Flows Sidebar. This conditionally renders the port and protocol's titles and content based on whether a flow's protocol is ICMP. Relevant tests are included.

Fixes: #276

Signed-off-by: Stacy Kim stacy.kim@ucla.edu

Signed-off-by: Stacy Kim <stacy.kim@ucla.edu>
@kimstacy kimstacy requested a review from a team as a code owner October 20, 2022 23:25
@kimstacy kimstacy requested review from geakstr and removed request for a team October 20, 2022 23:25
@kimstacy kimstacy changed the title Add ICMP info on Service Map and Flows Table feat: Add ICMP info on Service Map and Flows Table Oct 21, 2022
@kimstacy kimstacy requested review from yandzee and rolinh October 27, 2022 15:02
@kimstacy kimstacy merged commit a528184 into master Nov 1, 2022
@kimstacy kimstacy deleted the pr/stacy/add-icmp branch November 1, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show ICMP info on Service Map and Flows Table
2 participants