docs: update the cli doc with cidr range source/destination ip filter #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slayer321
requested review from
a team and
joamaki
and removed request for
a team
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
gandro
reviewed
May 31, 2022
gandro
added
⌨️ area/cli
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Great! Could you please squash the two commits together into one? Thanks! |
slayer321
force-pushed
the
pr/slayer321/cidr-docs-update
branch
from
6a5ee85
to
5a25671
Compare
gandro
reviewed
Jun 2, 2022
cmd/observe/flows.go
Outdated
| @@ -293,13 +293,13 @@ more.`, | |||
|
|
|||
| filterFlags.Var(filterVar( | |||
| "from-ip", ofilter, | |||
| "Show all flows originating at the given IP address.")) | |||
| "Show all flows originating at the given IP address. Each of the source IPs can be specified as an exact match (e.g. '1.1.1.1') or as a CIDR range (e.g.'1.1.1.0/24').")) | |||
| filterFlags.Var(filterVar( | |||
| "ip", ofilter, | |||
| "Show all flows related to the given IP address.")) | |||
There was a problem hiding this comment.
Sorry, forgot that last time around: Could also add the sentence here, since it also applies to this? e.g. Each of the IPs can be specified as an exact match (e.g. '1.1.1.1') or as a CIDR range (e.g.'1.1.1.0/24').
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
slayer321
force-pushed
the
pr/slayer321/cidr-docs-update
branch
from
efff3e8
to
1c02678
Compare
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the cli docs for source/destination IP filter
Fixes: #458
Signed-off-by: slayer321 sachin.maurya7666@gmail.com