Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

named reserved identites support for --{,from-,to-}identity #732

Merged
merged 2 commits into from
Jun 2, 2022
Merged

named reserved identites support for --{,from-,to-}identity #732

merged 2 commits into from
Jun 2, 2022

Commits on Jun 1, 2022

  1. cmd/observe: improve identity filter error messages 

    Before this patch, the identity flags errors were very verbose:

    % hubble observe --identity foo
    invalid argument "foo" for "--identity" flag: invalid security identity: foo: strconv.ParseUint: parsing "foo": invalid syntax

This patch shorten the error message to:

    % hubble observe --identity foo
    invalid argument "foo" for "--identity" flag: invalid security identity

The next commit will introduce support for named special identities,
which would render the integer parsing message moot.

Signed-off-by: Alexandre Perrin <alex@isovalent.com>
    @kaworu
    kaworu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    dc12e1c View commit details
    Browse the repository at this point in the history

  2. cmd/observe: add support for named reserved identities 

    f7c66cc ("printer: Display security identity in compact output")
introduced display of security identities including named reserved
identities, e.g. "(host)" instead of the equivalent "(identity:1)".

Before this patch, the --identity, --from-identity, and --to-identity
flags would only accept numerical values. This patch introduce support
for named reserved identites such as "host", "world", etc.

Signed-off-by: Alexandre Perrin <alex@isovalent.com>
    @kaworu
    kaworu committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4dbf58f View commit details
    Browse the repository at this point in the history