Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output: add absolute time to timestamp flag #151

Merged
merged 1 commit into from
Feb 13, 2023
Merged

output: add absolute time to timestamp flag #151

merged 1 commit into from
Feb 13, 2023

Conversation

sterchelen
Copy link
Contributor

@sterchelen sterchelen commented Feb 6, 2023 •
edited
Loading

This patch adds "absolute" as a new value to the timestamp flag.
When set, it prefixes each line with the current time.

Closes #149

@sterchelen sterchelen changed the title output: add absolute time as optional flag output: add absolute timestamp as optional flag Feb 6, 2023
brb
brb requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some minor comments.

internal/pwru/output.go Outdated Show resolved Hide resolved
internal/pwru/types.go Outdated Show resolved Hide resolved
@sterchelen
output: add absolute time to timestamp flag
b7d1c23 
This patch adds "absolute" as a new value to the timestamp flag.
When set, it prefixes each line with the current time.

Closes cilium#149
@sterchelen sterchelen changed the title output: add absolute timestamp as optional flag output: add absolute time to timestamp flag Feb 9, 2023
@sterchelen sterchelen requested a review from brb February 9, 2023 21:03
brb
brb approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brb brb merged commit bfe2465 into cilium:main Feb 13, 2023
@sterchelen sterchelen deleted the timestamp branch February 13, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add datetime to the output
2 participants
@sterchelen @brb