Fix code not matching the comment #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mozillazg <mozillazg101@gmail.com>
mozillazg
commented
Jul 8, 2023
jschwinger233
approved these changes
Jul 8, 2023
| @@ -162,7 +162,7 @@ func InjectFilter(program *ebpf.ProgramSpec, filterExpr string) (err error) { | |||
| // stack area is safe to use. Here we use stack from -40 | |||
| // because -32, -24, -16 are reserved for pcap-filter ebpf, see | |||
| // the comments in compile.go | |||
| StackOffset: 40, | |||
| StackOffset: 32, | |||
There was a problem hiding this comment.
I think you're right.
StackOffset: 32 means cloudfare/cbpfc is able to use stack area from r10-32 downwards, in another word, the first available stack pointer points to r10-40. Your change made it in line with the real situation, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#207
cc @jschwinger233