Implement DeleteTracingPolicy functionality

[inliquid]

• Implement DeleteTracingPolicy for gRPC service
• Implement "delete" command for tetra client
• Rename DelTracingPolicy -> DeleteTracingPolicy everywhere for consistency

Fixes #1110

[netlify]

✅ Deploy Preview for tetragon ready!

Name	Link
🔨 Latest commit	ae042f6
🔍 Latest deploy log	https://app.netlify.com/sites/tetragon/deploys/64b977af150f600008c5c643
😎 Deploy Preview	https://deploy-preview-1253--tetragon.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mtardy]

Hey 👋 thanks a lot for taking the time to write this PR, that's really nice of you!

If I may have a nit, would it be possible to keep delete instead of del everywhere (even in tetra)? I'm okay with having the whole delete word and changing this will unfortunately introduce a breaking change to the gRPC API (minimal I admit because it was not really exposed through a RPC but still).

[mtardy]

Taking the need for the change to also warn you that you will need to add your "sign-off" to the commit. Just a formality:

It looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation.

Concretely it consists of adding your real name and an email address to your git config and using git commit -s to write your commit message. You can use git commit --amend -s to add the signature to existing commits.

See more details on how to comply with the "sign-off" procedure

To add your name and email to your git config:

git config user.email "mail@example.com"
git config user.name "firstname lastname"

Note: add the --global flag after config to configure this by default for repositories on your host.

Then you can use for new commits:

git commit -s

Or for existing commits on which you want to add the signed-off-by statement:

git commit --amend -s

For more information, see this extract from git-commit(1) man page regarding the -s flag:

-s, --signoff, --no-signoff
   Add a Signed-off-by trailer by the committer at the end of the commit log
   message. The meaning of a signoff depends on the project to which you're
   committing. For example, it may certify that the committer has the rights to
   submit the work under the project's license or agrees to some contributor
   representation, such as a Developer Certificate of Origin. (See
   http://developercertificate.org for the one used by the Linux kernel and Git
   projects.) Consult the documentation or leadership of the project to which
   you're contributing to understand how the signoffs are used in that project.

   The --no-signoff option can be used to countermand an earlier --signoff
   option on the command line.

[mtardy]

And lastly, you can squash your commit and prefix the message with something like gRPC: implement DeleteTracingPolicy functionality.

I hope all of this is not too overwhelming, please feel free to ask any questions if needed. Again grateful that you took the time to implement this! :)

[inliquid]

Hey @mtardy, thank you for detailed explanations, I think I've fixed these points, is there anything else I can do?

[mtardy]

Hey @mtardy, thank you for detailed explanations, I think I've fixed these points, is there anything else I can do?

It's all good thanks a lot, let's run the CI and maybe ask for a review by Kornilios with who you interacted in the issue!

[kkourt]

Thanks!

I have a comment, please see bellow.

[mtardy]

Otherwise, for me, it's ready, any opinion @kkourt?

[kkourt]

LGTM, thanks! 🚀