Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Tetragon troubleshoot improve #2101

Closed
wants to merge 21 commits into from

Conversation

janvi01
Copy link
Contributor

@janvi01 janvi01 commented Feb 15, 2024

Improved doc around tetra bugtool, demo how to run it for all different installation k8s, container or systemd host installation.

Fixes #1974 second tick box.

@janvi01 janvi01 requested review from mtardy and a team as code owners February 15, 2024 08:04
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit cd1c898
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65cef7821dca59000880bba4
😎 Deploy Preview https://deploy-preview-2101--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtardy
Copy link
Member

mtardy commented Feb 15, 2024

Hey, welcome to Tetragon. Thanks for the taking the time to contribute!

Just for you to know I'm sorry but I just touched the troubleshooting guide yesterday in #2097, you might want to rebase your PR on main to make sure everything looks good :)

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Feb 15, 2024
cilium-renovate bot and others added 19 commits February 16, 2024 11:16
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
This is a breaking change but this metric is for internal use only so it
should not be too bad.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
It was discussed that this guide was redundant with the getting started
guides. It might get reused as an independent blog post.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
Signed-off-by: cilium-renovate[bot] <134692979+cilium-renovate[bot]@users.noreply.github.com>
This section was removed by cilium#2097.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Improve suid binary example, and rename titles to note privileges
escalation.

Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
@janvi01
Copy link
Contributor Author

janvi01 commented Feb 16, 2024

@mtardy I just rebased this PR to main and force-pushed.

@mtardy
Copy link
Member

mtardy commented Feb 16, 2024

It seems there's a bit of confusion about git rebase. When you use git rebase, you're essentially taking the commits from one branch and placing them on top of another branch.

For example, let's say you have a feature branch where you've been working on some changes and want to incorporate the latest changes from the main branch into your feature branch. Instead of merging main into your feature branch, you should rebase your feature branch onto main. This means you're taking each commit you've made in your feature branch, saving them aside temporarily, updating your feature branch to match the current state of main, and then applying each of your commits on top of the updated main. This makes your feature branch a linear extension of main, which can often result in a cleaner and more understandable history.

Here you imported some commits from main to your branch, it looks more like a merge commit but with every individual commit.

I would drop all the commits you imported from the main branch on your branch. Then sync main and do a git rebase main from your working branch.

@janvi01
Copy link
Contributor Author

janvi01 commented Feb 16, 2024

I think I should create a new PR, I took the rebase in another way.

@janvi01 janvi01 closed this Feb 16, 2024
@janvi01 janvi01 deleted the TetragonTroubleshootImprove branch February 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: improve troubleshooting Tetragon
3 participants