Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused PodInfo utility functions #2144

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove unused PodInfo utility functions #2144

merged 1 commit into from
Feb 27, 2024

Conversation

sfc-gh-gshe
Copy link
Contributor

@sfc-gh-gshe sfc-gh-gshe commented Feb 25, 2024

Per discussion with John, https://cilium.slack.com/archives/C03EV7KJPJ9/p1708702221445809?thread_ts=1708626799.584219&cid=C03EV7KJPJ9

This patch removes the unused FindPodByIP and FindServiceByIP and related test.

@sfc-gh-gshe sfc-gh-gshe requested a review from a team as a code owner February 25, 2024 06:38
@sfc-gh-gshe sfc-gh-gshe requested a review from tixxdz February 25, 2024 06:38
@tixxdz tixxdz added the release-note/minor This PR introduces a minor user-visible change label Feb 25, 2024
@tixxdz
Copy link
Member

tixxdz commented Feb 25, 2024

Much appreciated for the contributions ;-) ! some CI tests are failing can you please check?

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 171ac26
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65dcc40246f2650008222d7f
😎 Deploy Preview https://deploy-preview-2144--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Guozhen She <guozhen.she@snowflake.com>
@tixxdz
Copy link
Member

tixxdz commented Feb 27, 2024

ci failure seems unrelated tracked here: #2156

Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tixxdz tixxdz merged commit 9af6da4 into cilium:main Feb 27, 2024
30 of 31 checks passed
@lambdanis lambdanis added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR introduces a minor user-visible change labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants