-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[helm]: remove useless 'if' around a 'with' #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Welcome to Tetragon! Indeed, you are correct, the if statement is unnecessary! Thanks for the cleanup!
Thanks for the patch! However, it looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation. Concretely it consists of adding your real name and an email address to your git config and using See more details on how to comply with the "sign-off" procedure
To add your name and email to your git config: git config user.email "mail@example.com"
git config user.name "firstname lastname" Note: add the Then you can use for new commits: git commit -s Or for existing commits on which you want to add the git commit --amend -s For more information, see this extract from
|
Signed-off-by: Julien Acroute <julien.acroute@camptocamp.com>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@mtardy Hello, I just "sign-off" my commit. So this PR should be ready for the next step ;-) |
@Vampouille ahaha I did not check your GitHub profile so far!! Just recognized you, thanks for making a PR to Tetragon, that's nice! :) |
'with' already test if the values is empty so it's useless to add an extra 'if' around the 'with'