Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[helm]: remove useless 'if' around a 'with' #944

Merged
merged 1 commit into from
May 15, 2023

Conversation

Vampouille
Copy link
Contributor

'with' already test if the values is empty so it's useless to add an extra 'if' around the 'with'

@Vampouille Vampouille requested a review from a team as a code owner April 20, 2023 08:37
@Vampouille Vampouille requested a review from tpapagian April 20, 2023 08:37
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome to Tetragon! Indeed, you are correct, the if statement is unnecessary! Thanks for the cleanup!

@mtardy mtardy added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 26, 2023
@mtardy
Copy link
Member

mtardy commented Apr 26, 2023

Thanks for the patch! However, it looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation.

Concretely it consists of adding your real name and an email address to your git config and using git commit -s to write your commit message. You can use git commit --amend -s to add the signature to existing commits.

See more details on how to comply with the "sign-off" procedure

To add your name and email to your git config:

git config user.email "mail@example.com"
git config user.name "firstname lastname"

Note: add the --global flag after config to configure this by default for repositories on your host.

Then you can use for new commits:

git commit -s

Or for existing commits on which you want to add the signed-off-by statement:

git commit --amend -s

For more information, see this extract from git-commit(1) man page regarding the -s flag:

-s, --signoff, --no-signoff
   Add a Signed-off-by trailer by the committer at the end of the commit log
   message. The meaning of a signoff depends on the project to which you're
   committing. For example, it may certify that the committer has the rights to
   submit the work under the project's license or agrees to some contributor
   representation, such as a Developer Certificate of Origin. (See
   http://developercertificate.org for the one used by the Linux kernel and Git
   projects.) Consult the documentation or leadership of the project to which
   you're contributing to understand how the signoffs are used in that project.

   The --no-signoff option can be used to countermand an earlier --signoff
   option on the command line.

Signed-off-by: Julien Acroute <julien.acroute@camptocamp.com>
@netlify
Copy link

netlify bot commented May 12, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 0cad172
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/645e5ec278167400080394f8
😎 Deploy Preview https://deploy-preview-944--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Vampouille
Copy link
Contributor Author

@mtardy Hello, I just "sign-off" my commit. So this PR should be ready for the next step ;-)

@mtardy
Copy link
Member

mtardy commented May 15, 2023

@Vampouille ahaha I did not check your GitHub profile so far!! Just recognized you, thanks for making a PR to Tetragon, that's nice! :)

@mtardy mtardy requested review from mtardy and removed request for tpapagian May 15, 2023 09:08
@mtardy mtardy merged commit 3bb1add into cilium:main May 15, 2023
@Vampouille Vampouille deleted the fix_chart branch July 26, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants