Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to configure the JDK in the plugin #9

Closed
renaudpawlak opened this issue Mar 1, 2016 · 2 comments
Closed

Add a way to configure the JDK in the plugin #9

renaudpawlak opened this issue Mar 1, 2016 · 2 comments
Milestone

Comments

@renaudpawlak
Copy link
Contributor

At this point, JSweet necessarily uses the JAVA_HOME variable. We need a way to configure the JDK without having to change that variable (it is global and may conflict with other Java software).

My favorite method would be to simply get the path from the SDK used by the project, which would have to be a JDK >= 1.8.

As a fallback, we may have a configuration field to set the JDK path in the JSweet preferences.

@ivmarkov
Copy link

ivmarkov commented Mar 2, 2016

That would be my favorite as well. Have in mind that Eclipse does not need the JDK and can happily use a JRE as well (for obvious reasons). So perhaps the jsweet eclipse plugin should indicate to the user that the Java Runtime bound to the jsweet project is not really a JDK but a JRE.

@renaudpawlak renaudpawlak modified the milestones: 0.9.4, 0.9.3 May 25, 2016
renaudpawlak added a commit that referenced this issue May 25, 2016
@renaudpawlak
Copy link
Contributor Author

The last commit should implement the "favorite" method. Probably need some feedback to see if it works for all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants