-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline override in enum not supported #560
Inline override in enum not supported #560
Conversation
Thanks @lucgirardin, this is a tricky case. |
I will certainly have a look whether there is a simple solution to handle this tricky case. Of course, it took me seconds to modify my code so that it is compatible with JSweet, so the incentive to find a complete solution is low. I have a few additional cases I could add. The question is how much you want JSweet to be compatible with Java. One possibility could simply be to document these cases (as issues?) so that other users can be directed to workarounds. The other could be to just have a list of additional test cases that JSweet do not currently handle, so that eventually somebody will fix them. What's your take? |
Thanks for your answer. Having unsupported cases in an @ignore test class could help, nice idea! For the record, our wish is to stick as much as possible to the Java syntax but we are willing to accept a small percentage of.unsupported constructs if they are unusual. I hope my answer will clarify how we stand. Please tell me if you have any other question. We could keep this PR opened and perhaps change the title to "add a @ignore test class to list unsupported transpilation cases" what do you think? |
…eet3.0-moduleInfo
…/jsweet into JSweet3.0-moduleInfo
Signed-off-by: Luc Girardin <luc.girardin@macrofocus.com>
Nevermind, I will merge as is :) |
That's sweet... thanks for being lenient, I was underwater lately! |
Added two additional enum definitions to the test cases: ToStringEnum doesn't compile while ToStringInnerEnum does.