Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added indentWithIndicator to Printer #398

Closed

Conversation

KostadinAlmishev
Copy link

Fixes #130

To indent entire array when indicatorIndent != 0, to printer should be passed indentWithIndicator = true

@zarthross
Copy link
Member

Thanks for the submission, but it looks that change won't be binary compatible.... What needs to be done is deprecating Config and the current make function and creating a new ConfigBuilder, similar to what Ember does here: https://github.com/http4s/http4s/blob/00fcd90fcd26259026908dd4e1bff853432ac3f0/ember-client/shared/src/main/scala/org/http4s/ember/client/EmberClientBuilder.scala#L44. With the builder pattern we'll be able to add options compatibly going forward!

@hamnis
Copy link
Contributor

hamnis commented Jun 13, 2024

closing in favour of #406

@hamnis hamnis closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of dictionaries not indented correctly
3 participants