-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added indent with indicators to yaml-v12 #406
Conversation
-Also support NonPrintableStyle
Also made relevant changes to circe-yaml. That required implementation of Also the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @zarthross will need to have the final word
circe-yaml-v12/src/main/scala/io/circe/yaml/v12/PrinterBuilder.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes need to be made, but otherwise it looked good.
Thank you for your review. I made the changes you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank your for the contribution!
Enables to indent yaml like:
This applies only to circe-yaml-v12. I could not come up with a way to do it for circe-yaml in a binary compatible way (I would assume this is binary compatible).
Test copied from #398 and implemented PrinterBuilder builder as suggested there.
I also added deprecations. Values are just a guess and maintainers can of course change then as they see fit.