Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAE setup instructions are confusing #2134

Closed
travis opened this issue Mar 12, 2018 · 1 comment · Fixed by #2142
Closed

GAE setup instructions are confusing #2134

travis opened this issue Mar 12, 2018 · 1 comment · Fixed by #2142
Assignees
Labels
unclear confusing language

Comments

@travis
Copy link
Contributor

travis commented Mar 12, 2018

  • "Paste this into a new environment variable’s “Value” field" <- not clear whether "this" is the contents of the JSON key or something else
  • not clear which parts of the config.yml are necessary
  • I think GCR_CREDS and GOOGLE_AUTH are both used to refer to the same environment variable (GOOGLE_AUTH in most places, GCR_CREDS in the comment in the sample config.yml)
  • this document doesn't specify which roles the Service Account needs to have to work properly with CircleCI

This issue is about https://circleci.com/docs/2.0/google-container-engine/ (source file: https://github.com/circleci/circleci-docs/blob/master/jekyll/_cci2/google-container-engine.md)

@smart-alek smart-alek self-assigned this Mar 13, 2018
@smart-alek smart-alek added the unclear confusing language label Mar 13, 2018
@smart-alek
Copy link
Contributor

Hey @travis, good to see you!

I've actually already got a full revision of that document in the works, so I'll go ahead and incorporate some of your suggestions there. In the meantime, glance at this doc and see if you fare any better (it's more specific and recent): https://circleci.com/docs/2.0/google-auth/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unclear confusing language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants