Skip to content

add settings.toml to the rendered screenshots if needed. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023

Conversation

FoamyGuy
Copy link
Collaborator

Also fixed a bug with code file icon showing empty file for some files that should have been the code icon.

Whether to render settings.toml or not is determined by whether any of a certain list of libraries are used by the project. The current list is:

LIBRARIES_THAT_REQUIRE_SETTINGS = [
    "adafruit_requests.mpy",
    "adafruit_esp32spi",
    "adafruit_minimqtt",
    "adafruit_portalbase",
    "adafruit_azureiot",
]

Here's one example of the new screenshot with settings.toml included
MagTag_Quote_Board

If the project doesn't have one of the specified libraries used it will render the same as it would have previously. Here is one without settings.toml:

AutoSunglasses

@FoamyGuy FoamyGuy requested a review from kattni May 18, 2023 01:02
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE it! Thank you so much for getting this updated!

@kattni kattni merged commit da6907b into circuitpython:main May 18, 2023
@FoamyGuy FoamyGuy mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants