Skip to content

Many changes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 4, 2021
Merged

Many changes #2

merged 8 commits into from
May 4, 2021

Conversation

jepler
Copy link
Contributor

@jepler jepler commented May 3, 2021

This

  • removes the HTML generator entirely
    • I could put it back but I didn't feel like figuring out reuse-compliant license statements for it
    • but I don't think we're going to use it?
  • moves the python code up a directory level
  • adds pre-commit and fixes pre-commit compliance (reuse, black, pylint)
  • adds the .circuitpython.skip tag to avoid generating an image for ourselves


BUNDLE_DATA = "latest_bundle_data.json"
BUNDLE_TAG = "latest_bundle_tag.json"

LEARN_GUIDE_REPO = os.environ.get('LEARN_GUIDE_REPO', "../../Adafruit_Learning_System_Guides/")
LEARN_GUIDE_REPO = os.environ.get(
"LEARN_GUIDE_REPO", "../../Adafruit_Learning_System_Guides/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the scrips in the root of the repo this is now one level off in my environment, so ../Adafruit_Learning_System_Guides/ is the value I use now.

But this is dependent on the environment it's running in and may end up needing to change again when it's setup with the CI, I'm going to merge it for now. Perhaps when running in CI there is some other way it can access the repo that it's running inside of

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually I just noticed this is an environment variable now and the string given I guess is the default used if it's not present. So the hardcoded value doesn't need to change on different environments.

Thanks for all of these improvements!

@FoamyGuy FoamyGuy merged commit 63ce34f into circuitpython:main May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants