-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix p7zip-rar error and files with ' or " by using arg lists instead of strings #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trings (ciromattia#581)" (ciromattia#628)" This reverts commit b528dab.
axu2
changed the title
Popen
fix p7zip-rar error and files with ' or " by using arg lists instead of strings
Dec 3, 2023
Also removed some utf-8 encodings since it caused crashes on files with non utf8 characters. Now it only encodes utf8 in the same places originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using the slightly unsafe
shell=True
parameter will actually throw aFileNotFoundError
if I call a command that doesn't exist (like if kindlegen or 7z aren't installed). Called out explicitly here:https://docs.python.org/3/library/subprocess.html#exceptions
So prior code in #581 actually crashed when 7z and kindlegen aren't installed during the initial check. Our code prevent selecting MOBI/zip formats afterward, so no further exceptions expected.
So added try: except blocks as needed during initial checks.