-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying target metadata in cli #675
Conversation
This works great |
Why not --author --title --summary instead of parsing a long string? The parsing could cause issues and I've never seen a CLI like that. Maybe like Also, is modifying ComicInfo.xml an option? |
I don't have a strong opinion on this. I also use comictagger, which does it like this aswell. Also, this is more flexible in case of adding more metadata fields.
It is not. While ComicInfo.xml has separate fields for series title, volume number and volume title, mobi only has title. So I combine the three fields into one, e.g.: "One Piece 1: Romance Dawn" |
ed52716
to
e362867
Compare
will this get merged soon? |
To preface, I'm not a CLI user and don't edit metadata, so excuse me if I say anything uninformed. I see, indeed that's how the ComicTagger CLI works. https://github.com/comictagger/comictagger/wiki/UserGuide#cli-user-guide. I'm not sure how I feel about owning parsing code however. Is there anything wrong with naming a I understand that And is summary used anywhere in the Kindle UI? Maybe we could simplify with just an --author tag. |
I've looked around in my Kindle and I couldn't find any mention of the summary, so honestly yeah --author tag would work great |
@gonsanbo is there anything wrong with using comictagger or builtin kcc metadata editor to add author field? |
I can't use the inbuilt editor because I was writing a script to automate the process but I didn't know about comictagger, I'll try using that, thanks :) |
@gonsanbo let me know how it works, if it modifies the source file that might be problematic for some workflows and an We already have a |
@axu2 well I tried comictagger and its working on my script. Only disadvantage is I have to copy source files instead of hardlinking them since it edits the files, but its alright. I wouldn't mind an --author tag if it ever gets merged |
Try the build in to see if it works for you. Edit: closing for now, if you need more than author feel free to re-open. |
series would be a nice addition especially when you organise your ebooks and you want them grouped together by series like One Piece, Blue Lock, Berserk ... |
This adds a new cli parameter to manually specify metadata to be added to the target file. The metadata is specified as follows:
--metadata "title=My Comic;author=The Author"
;
and=
can be used in values by escaping them with\
I only tested this by converting cbz to epub and mobi.
Relates to issue #673