Skip to content

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Jun 10, 2020

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/development-guide.git development-guide
    cd development-guide
    git remote add skeleton https://github.com/cisagov/skeleton-generic.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the branch,
    commit, and push your changes:

    git add requirements-test.txt requirements.txt 
    git commit --message="Resolve Lineage conflicts."
    git push --force --set-upstream origin lineage/skeleton
  5. Wait for all the automated tests to pass.

  6. Check the "Everything is cool" checkbox below:

    • ✌️ The conflicts in this pull request have been resolved.
  7. Mark this draft pull request "Ready for review".


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

jsf9k and others added 3 commits June 9, 2020 15:10
setuptools usually comes along with pip, but wheel does not.  Using
wheel where possible to build python extensions is more modern and
more security conscious than using setup.py.
Add setuptools and wheel as pip dependencies
@felddy felddy force-pushed the lineage/skeleton branch from f4ef3ae to 97ddb23 Compare June 10, 2020 03:38
@felddy felddy marked this pull request as ready for review June 10, 2020 03:43
@felddy felddy requested review from felddy and dav3r June 10, 2020 03:46
Copy link
Contributor

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0️⃣

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤐

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to install the wheel pip package for this repo? Why is this one different?

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking approval until my question is addressed.

@felddy
Copy link
Contributor

felddy commented Jun 15, 2020

Talked with @jsf9k. Will add wheel somewheres.

This implements the upstream changes from skeleton.
@felddy felddy requested a review from jsf9k June 15, 2020 18:37
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎡

@felddy
Copy link
Contributor

felddy commented Jun 15, 2020

Added to wheel to setup.py. I think wheel was less of an issue for Mac users (me anyway) than @jsf9k . My virtual environments are build with wheel pre-installed. Anyway. This should fix it for more people.

@felddy felddy merged commit 5ce5836 into develop Jun 15, 2020
@felddy felddy deleted the lineage/skeleton branch June 15, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants