This repository was archived by the owner on Aug 24, 2023. It is now read-only.
Update to skeleton-aws-lambda, Pare CODEOWNERS, and Add Lineage Configuration #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an appropriately configured lineage.yml Pare down CODEOWNERS to align with contributors to this project.
Pull in skeleton-aws-lambda so future skeleton updates can be performed using that skeleton. It was created after this project, which is based on skeleton-python-library. Since it is a common ancestor it was straightforward to switch.
The skeleton uses a setup_logging function to DRY logging setup between the lambda handler and the functionality code. The change resulted in a percieved decrease in testing coverage by coveralls. This adds in the test (tweaked) from the skeleton to provide coverage of the setup_logging function.
mcdonnnj
requested review from
a team,
dav3r,
felddy,
jsf9k and
mzack5020
as code owners
dav3r
approved these changes
Jun 18, 2020
1 task
cisagovbot
pushed a commit
that referenced
this pull request
Nov 24, 2020
⚠️ CONFLICT! Lineage pull request for: skeleton
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This updates this project to align with cisagov/skeleton-aws-lambda, reduces the
CODEOWNERSfile to the primary contributors, and adds a Lineage configuration to ease future maintainability.This project was started before I created cisagov/skeleton-aws-lambda, so it was based on cisagov/skeleton-python-library. In order to support Lineage correctly I needed to pull from cisagov/skeleton-aws-lambda to, hopefully, readily merge future Lineage PRs.
💭 Motivation and Context
Having repositories tie in to the newer Lineage process is good for maintainability.
CODEOWNERSshould reflect "true" owners.🧪 Testing
Automated testing.
📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist