Skip to content
This repository was archived by the owner on Aug 24, 2023. It is now read-only.

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Dec 3, 2020

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-aws-lambda.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/findings-data-import-lambda.git findings-data-import-lambda
    cd findings-data-import-lambda
    git remote add skeleton https://github.com/cisagov/skeleton-aws-lambda.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add .github/workflows/build.yml .github/workflows/release.yml Dockerfile build.sh 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Check the "Everything is cool" checkbox below:

    • ✌️ The conflicts in this pull request have been resolved.
  7. Mark this draft pull request "Ready for review".


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 24 commits November 20, 2020 12:22
Removed name because it was not more informative than the default. Swapped out
a hardcoded job reference for the github.job context value. Switch the base
cache key to a step environment value so we can set it once and reuse. Removed
additional restore-key value that might have undesirable results.
Use the full semver for the installed Python version in cache keys.
Switch lambda building to use the Python version given as a build argument.
Change the build script to accept an argument to use the correct major.minor
version from the lambci imagine being used.
When building the lambda we only need Docker tools which are pre-installed on
the GH Actions runners. Thus, we do not need to set up a Python environment and
install Python requirements.
Revert the complicated output name bits from the build script and Actions
workflows. Instead the Actions workflows will handle any fancy asset naming.
Remove reverted IS_RELEASE argument. Add some comments explaining
functionality. Update the LABELs being set to reflect the current best
practices.
Expand the comment to reference what the command is doing since zip does not
have long options.
Update the test and build workflow jobs to use the actions/cache style that was
done for the lint job.
Lineage pull request for: skeleton
…_cache_keys

Use Full semver of Installed Python Version in Cache Keys
Lineage pull request for: skeleton
Update Lambda Building and Related GHA Job
@mcdonnnj mcdonnnj marked this pull request as ready for review December 4, 2020 20:24
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@mcdonnnj mcdonnnj merged commit 98db142 into develop Dec 7, 2020
@mcdonnnj mcdonnnj deleted the lineage/skeleton branch December 7, 2020 18:02
cisagovbot pushed a commit that referenced this pull request Aug 10, 2021
⚠️ CONFLICT! Lineage pull request for: skeleton
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants