Pull in upstream updates #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup-env: A tool to automate a development environment setup.
Lineage pull request for: skeleton
Notable version changes: - docker-pre-commit v2.0.0 This release includes the addition of two new hooks: hadolint and hadolint-system. These allow for linting Dockerfiles with the hadolint Docker image or a system installation of hadolint respectively. - isort 5.0.7 This release takes us from isort 4 to isort 5. There are a multitude of changes with information available on the isort 5 release page at https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/ The most notable feature for us is the addition of built-in profiles for isort to run under. These profiles provide settings for conforming to various popular styles, and black is one of the profiles.
Autoupdates to pre-commit Hooks for 2020-07
⚠️ CONFLICT! Lineage pull request for: skeleton
Switch the workflow to use cachev2. This puts us up to date and allows us to consolidate into one cache item.
Keep it up-to-date even though we are not currently using features added in v2.
Make the job name the first part of the cache key since it is the only part that isn't variable.
…nd_cache_actions_to_v2 Update actions/cache and actions/setup-python to v2
All jobs should perform identical work in a consistent manner.
Lineage pull request for: skeleton
Autoupdate pre-commit and Additional Maintenance
Add "requirements.txt" to the actions/cache key for the test job to match what was done for the lint job. Expand the option to pip in requirements.txt to its full, more descriptive form. This matches efforts to do this elsewhere in our codebases.
⚠️ CONFLICT! Lineage pull request for: skeleton
Update action/upload-artifact Version
Also use the long form of -e in requirements-test.txt.
Remove the execute bit in file permissions and remove the shebang line. Since this is configured as a Python package that is installed using pip, it should only use `python -m example` or the `example` console script to be run.
We change the "Install Terraform-docs" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
This changes from using an environment variable to using a step output to store the Go version that is installed. This mirrors changes made to the other program versions and how they're stored.
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
Remove the manual exclusion of the `converge.yml` file in the default molecule scenario. With the changes in cisagov/skeleton-ansible-role#88 this exclusion is no longer necessary.
Instead of excluding molecule configurations for systemd individually we instead direct ansible-lint to process any of these configurations in scenario directories as plain yaml files. This mirrors how ansible-lint handles `molecule.yml` files in scenario directories by default.
Lineage pull request for: skeleton
Add Support for Python 3.10
Override the default by setting `fail-fast` to `false` for the test and build jobs in our GHA build workflow. This ensure that all matrix jobs run regardless of a failure.
…_test_and_build_jobs Disable `fail-fast` for GitHub Actions Jobs with a Matrix Strategy
Update pre-commit hooks using `pre-commit autoupdate`.
Update `pre-commit` hooks
…onfiguration Update `ansible-lint` Configuration
Lineage pull request for: skeleton
Perform all changes necessary to satisfy the pre-commit configuration.
mcdonnnj
added
the
upstream update
jsf9k
approved these changes
Mar 6, 2022
dav3r
requested changes
Mar 7, 2022
Reference the correct path when bumping versions. Co-authored-by: dav3r <daver@geekpad.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates this repository with the latest in cisagov/skeleton-python-library. This includes a configuration for cisagov/action-lineage so it will get future updates automatically.
💭 Motivation and context
I was reminded of this project this week and noticed that it was woefully out of date.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
to reflect the changes in this PR.