⚠️ CONFLICT! Lineage pull request for: skeleton

[cisagovbot]

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-python-library.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

1. Take ownership of this pull request by removing any other assignees.

2. Clone the repository locally, and reapply the merge:

   git clone git@github.com:cisagov/skeleton-aws-lambda.git skeleton-aws-lambda
   cd skeleton-aws-lambda
   git remote add skeleton https://github.com/cisagov/skeleton-python-library.git
   git remote set-url --push skeleton no_push
   git switch develop
   git checkout -b lineage/skeleton --track origin/develop
   git pull skeleton HEAD
   git status

3. Review the changes displayed by the status command. Fix any conflicts and
   possibly incorrect auto-merges.

4. After resolving each of the conflicts, add your changes to the branch,
   commit, and push your changes:

   git add .github/workflows/build.yml 
   git commit --message="Resolve Lineage conflicts."
   git push --force --set-upstream origin lineage/skeleton

5. Wait for all the automated tests to pass.

6. Check the "Everything is cool" checkbox below:

   • ✌️ The conflicts in this pull request have been resolved.

7. Mark this draft pull request "Ready for review".

---

Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

[jsf9k]

This is less of a change request and more of a question I'd like answered before this is merged.

It seems odd that the test portion of the build.yml workflow runs against python 3.6, 3.7, and 3.8 while the build portion of that workflow only runs against 3.8. I assume the latter is because you only want to build for the latest python version that Lambda supports, which is currently 3.8. With that in mind, is it really necessary to test against 3.7 and 3.6? Or should we build for all three versions and let the user choose which version of python to use?

[mcdonnnj]

This is less of a change request and more of a question I'd like answered before this is merged.

It seems odd that the test portion of the build.yml workflow runs against python 3.6, 3.7, and 3.8 while the build portion of that workflow only runs against 3.8. I assume the latter is because you only want to build for the latest python version that Lambda supports, which is currently 3.8. With that in mind, is it really necessary to test against 3.7 and 3.6? Or should we build for all three versions and let the user choose which version of python to use?

That's a fair point. I've changed the existing build workflow to build_lambda to reflect that all it's doing is generating a lambda artifact. That process is done in a Docker container and doesn't mirror the typical Python build process. I added the cisagov/skeleton-python-library build workflow in unmolested so that the code's build is tested in addition to a lambda artifact being generated.

[dav3r]

👍 👍