Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Oct 7, 2020

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-python-library.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/skeleton-aws-lambda.git skeleton-aws-lambda
    cd skeleton-aws-lambda
    git remote add skeleton https://github.com/cisagov/skeleton-python-library.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the branch,
    commit, and push your changes:

    git add eal/__main__.py src/example/example.py tests/test_example.py 
    git commit --message="Resolve Lineage conflicts."
    git push --force --set-upstream origin lineage/skeleton
  5. Wait for all the automated tests to pass.

  6. Check the "Everything is cool" checkbox below:

    • ✌️ The conflicts in this pull request have been resolved.
  7. Mark this draft pull request "Ready for review".


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 14 commits September 28, 2020 16:47
Also use the long form of -e in requirements-test.txt.
Remove the execute bit in file permissions and remove the shebang line. Since
this is configured as a Python package that is installed using pip, it should
only use `python -m example` or the `example` console script to be run.
Workflow improvements: 🦁 set-env, and 🐯 python-3.9, and 🐻 dependabot, oh my!
Lineage pull request for: skeleton
…port

Add Support for Running as Python Module
@mcdonnnj mcdonnnj marked this pull request as ready for review October 22, 2020 15:20
@mcdonnnj mcdonnnj requested review from dav3r and felddy as code owners October 22, 2020 15:20
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me!

Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@mcdonnnj mcdonnnj merged commit 8ccc56c into develop Oct 22, 2020
@mcdonnnj mcdonnnj deleted the lineage/skeleton branch October 22, 2020 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants