This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Update Lambda Building and Related GHA Job #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch lambda building to use the Python version given as a build argument. Change the build script to accept an argument to use the correct major.minor version from the lambci imagine being used.
When building the lambda we only need Docker tools which are pre-installed on the GH Actions runners. Thus, we do not need to set up a Python environment and install Python requirements.
Revert the complicated output name bits from the build script and Actions workflows. Instead the Actions workflows will handle any fancy asset naming.
Remove reverted IS_RELEASE argument. Add some comments explaining functionality. Update the LABELs being set to reflect the current best practices.
jsf9k
approved these changes
Dec 2, 2020
Expand the comment to reference what the command is doing since zip does not have long options.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates the GitHub Actions jobs to generate a lambda artifact for every supported version of Python. The
Dockerfileandbuild.shscript have been updated to support this change.💭 Motivation and Context
The Python package being used is built for all supported Python versions, so I felt the generated Lambda artifact should be built for all Python versions supported by both the package and AWS. This makes it easier to use generated artifacts for deployments if desired.
🧪 Testing
Automated testing passes and lambda artifacts are successfully generated.
✅ Checklist