This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Lineage pull request for: skeleton #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per prettier/prettier#8937 the pre-commit hook has been moved to https://github.com/pre-commit/mirrors-prettier. I have also updated to the latest version in that repository.
At some point the python GitHub organization renamed to psf (Python Software Foundation). Although it redirects with no issue, I think it should be updated to reflect the current repository URL.
Two hooks had trailing '.git's in the URLs. Although this is not a problem, we should be consistent in how we format things.
Enabled 'check-case-conflict' because of our mixed Linux and macOS development. Although APFS supports case-sensitive containers, it is not the default as far as I am aware. Linux filesystems are typically case-sensitive however. With the merge of cisagov/development-guide#42 we now have a TOML file in a repository, so it does not hurt to add this hook in case more are added in the future.
I missed that this repository was transfered from the creator, Timothy Crosley, to the PyCQA organization.
The --strict flag will cause the yamllint hook to exit with a non-zero exit code when warnings are found instead of only when errors are found.
pre-commit Hook Maintenance and Update
Add the pre-commit-packer Repo and Hooks to the pre-commit Configuration
Use the --strict Flag for the yamllint pre-commit Hook
⚠️ CONFLICT! Lineage pull request for: skeleton
cisagovbot
requested review from
dav3r,
felddy,
hillaryj,
jsf9k and
mcdonnnj
as code owners
jsf9k
approved these changes
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-python-library.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage