-
Notifications
You must be signed in to change notification settings - Fork 12
Separate Coveralls build results by platform #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the Coveralls integration to use unique flag names that include both Python version and platform information, addressing issues with parallel test result processing across multiple platforms.
- Modified the
flag-name
parameter in the Coveralls GitHub Action to include platform information alongside Python version - This ensures unique identifiers for each test run combination, preventing namespace collisions in Coveralls reporting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Separate Coveralls build results by platform
Separate Coveralls build results by platform
Separate Coveralls build results by platform
Currently we only set the flag for build results to the Python version, but since we test across platforms now we should also separate by the platform as well.
7f4d2a4
to
f063840
Compare
🗣 Description
This pull request updates the flag used for Coveralls test results to include the platform and not just the Python version.
💭 Motivation and context
The description for using Coveralls in parallel such as we do indicated that the
flag-name
variable must be unique. Since we have started multi-platform testing that has not been the case and it appears to be causing problems in getting Coveralls test results reported. This appears to rectify the issue.🧪 Testing
Automated tests pass. I verified that Coveralls appears to be processing the test results whereas before it seemed unable to process the uploaded files (likely because of namespace collision).
✅ Pre-approval checklist