Skip to content

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request updates the flag used for Coveralls test results to include the platform and not just the Python version.

💭 Motivation and context

The description for using Coveralls in parallel such as we do indicated that the flag-name variable must be unique. Since we have started multi-platform testing that has not been the case and it appears to be causing problems in getting Coveralls test results reported. This appears to rectify the issue.

🧪 Testing

Automated tests pass. I verified that Coveralls appears to be processing the test results whereas before it seemed unable to process the uploaded files (likely because of namespace collision).

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj requested review from a team and Copilot September 22, 2025 07:13
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code labels Sep 22, 2025
@mcdonnnj mcdonnnj added the test This issue or pull request adds or otherwise modifies test code label Sep 22, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Coveralls integration to use unique flag names that include both Python version and platform information, addressing issues with parallel test result processing across multiple platforms.

  • Modified the flag-name parameter in the Coveralls GitHub Action to include platform information alongside Python version
  • This ensures unique identifiers for each test run combination, preventing namespace collisions in Coveralls reporting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Skeleton Maintenance Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 22, 2025
Separate Coveralls build results by platform
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 22, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 22, 2025
Separate Coveralls build results by platform
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@mcdonnnj mcdonnnj added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@jsf9k jsf9k added this pull request to the merge queue Sep 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2025
@mcdonnnj mcdonnnj added this pull request to the merge queue Sep 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2025
Separate Coveralls build results by platform
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2025
@mcdonnnj mcdonnnj added the hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation label Sep 23, 2025
Currently we only set the flag for build results to the Python version,
but since we test across platforms now we should also separate by the
platform as well.
@mcdonnnj mcdonnnj force-pushed the improvement/update_coveralls_flag branch from 7f4d2a4 to f063840 Compare September 23, 2025 06:46
@mcdonnnj mcdonnnj merged commit 8ad1792 into develop Sep 23, 2025
157 of 160 checks passed
@mcdonnnj mcdonnnj deleted the improvement/update_coveralls_flag branch September 23, 2025 08:50
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Skeleton Maintenance Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation test This issue or pull request adds or otherwise modifies test code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants