Fix permission checks on contact create popups #13506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The permissions checked to show buttons to create a new contact via entityRef were not the correct permissions to actually create a contact in a profile form, which meant that some users could see the buttons but not be able to add contacts.
Before
Removing "profile listings and forms" and "profile create" permissions from a user would result in the buttons still appearing but an error when clicking on it.
After
Button appears correctly when user has permission. Note in screenshot the user lacks admin or profile permissions, so no create buttons are shown in the entityRef widget.