dev/core#534 Re-instate pay-now button #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is regression - likely for a few months? Fix adds a unit test & does some additional tidy up We should consider for 5.12
|
(Standard links)
|
magnolia61
reviewed
Apr 15, 2019
| // This is required for tpl logic. We should move away from hard-code this to adding an array of actions to the row | ||
| // which the tpl can iterate through - this should allow us to cope with competing attempts to add new buttons | ||
| // and allow extensions to assign new ones through the pageRun hook | ||
| $row[0]['contribution_status_name'] = CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $row['contribution_status_id']);; | ||
| if ('Pending' === CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $row['contribution_status_id'])) { |
There was a problem hiding this comment.
Hope to see "Partially Paid" here soon. I know work is in progress for that. Thank you for that Eileen!
|
@eileenmcnaughton Thanks for taking care of this. Applied Patch to the RC, tested and it works. I do think it should be in 5.12 as well. |
|
Merging as per Kevin's testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is regression - likely for a few months? Fix adds a unit test specifically for this button & does some additional tidy up
We should consider for 5.12
Before
Pay now btn missing
After
Pay now btn back
Technical Details
@kcristiano
Comments