Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] remove CRM_Core_Error check #16136

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 22, 2019

Overview

Remove an IF that should always be true

Before

Handling for CRM_Core_Error when calling a function not expected to return a core error.

After

Handling removed, code easier to understand

Technical Details

I'm convinced there is no reason why find() should return a core_error & hence if it did we wouldn't want
to keep calm & carry on - smells a lot like copy & paste. Also makes code hard to understand

Comments

I'm convinced there is no reason why find should return a core_error & hence if it did we wouldn't want
to keep calm & carry on - smells a lot like copy & paste. Also makes code hard to understand
@civibot
Copy link

civibot bot commented Dec 22, 2019

(Standard links)

@civibot civibot bot added the master label Dec 22, 2019
@seamuslee001
Copy link
Contributor

Change makes sense to me merging

@seamuslee001 seamuslee001 merged commit d129a1b into civicrm:master Dec 23, 2019
@seamuslee001 seamuslee001 deleted the member_test branch December 23, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants