[REF] remove CRM_Core_Error check #16136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove an IF that should always be true
Before
Handling for CRM_Core_Error when calling a function not expected to return a core error.
After
Handling removed, code easier to understand
Technical Details
I'm convinced there is no reason why find() should return a core_error & hence if it did we wouldn't want
to keep calm & carry on - smells a lot like copy & paste. Also makes code hard to understand
Comments