dev/core#1979 - Incorrect comparison of status_id when changing status of linked cases

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1979

1. Create a case.
2. Create another case.
3. Create a link cases activity and link them.
4. Create a change case status activity and check the box to update related cases.
5. Click save.

It ends up working anyway and updating the other case but it's not comparing 'status_id' properly because the field available is actually a label called 'case_status', and you get an E_NOTICE telling you that: Undefined index: status_id in CRM_Case_Form_Activity_ChangeCaseStatus::beginPostProcess() (line 137 of .../CRM/Case/Form/Activity/ChangeCaseStatus.php).

Technical Details

It works because it ends up updating cases it doesn't need to update by changing them to the same as they already are. The other option was to just remove the if and let it continue to update those.

civicrm-core/CRM/Case/Form/Activity/ChangeCaseStatus.php

Line 137 in a841215

if ($currentCase['status_id'] != $params['case_status_id']) {

Comments

Has test

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@lcdservices any chance you can review?

[eileenmcnaughton]

or maybe @jitendrapurohit

[jitendrapurohit]

was able to replicate the e-notice and confirm that the PR seems to fix it. The unit test asserts the fix correctly so think it is good to merge 👍

[demeritcowboy]

Thanks @jitendrapurohit !

[yashodha]

@demeritcowboy @jitendrapurohit looks good, merging this.