Remove redundant custom field types #18378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Test Result (1 failure / -13) |
The html_type 'Select Country' and 'Select State/Province' serve no purpose. They are the same as Select, just with a different data_type. This adds an APIv3 shim to display the old types.
colemanw
force-pushed
the
noMoreStupidHTMLTypes
branch
from
c02724b
to
a7bcb32
Compare
|
Jenkins re test this please |
|
@colemanw this I think will work fine but we will need a corresponding PR to update here https://github.com/civicrm/civicrm-drupal/blob/7.x-master/modules/views/civicrm.views.inc#L567 and maybe https://github.com/civicrm/civicrm-drupal/blob/7.x-master/modules/views/civicrm.views.inc#L465 but probably doesn't matter that one |
|
Ok @seamuslee001 I have opened civicrm/civicrm-drupal#622 |
|
Changes look good and I have tested the views changes and they work as well merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Custom field
html_type'Select Country' and 'Select State/Province' served no purpose and have been removed. They are the same as 'Select', just with a different data_type.Before
The
html_types'Select Country' and 'Select State/Province' exist.After
Now they don't.
Technical Details
This adds an APIv3 shim to display the old types, which should mitigate the impact on APIv3 users.
No shims added for APIv4 since it's relatively new.