dev/core#2039 [REF] Follow up cleanup from Event Location

[eileenmcnaughton]

Overview

CRM_Core_BAO_Block::create & CRM_Core_BAO_Address::create are no longer called with the entity param

• remove support

Before

$entity param supported but never passed in

After

poof

Technical Details

Usage removed in #18586

Comments

I did earlier do universe searches

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test fail unrelated https://test.civicrm.org/job/CiviCRM-Core-PR/37140/testReport/junit/E2E.Core/PrevNextTest/testDeleteByCacheKey/ @demeritcowboy fyi on the test -

@seamuslee001 @colemanw if we can merge this I'll clean up the 'now-less-contaminated' Address::create along the lines of how we did Website::Create ie. move the 'multiple' functionality to a new function, support calling it in a deprecated way via the existing for 'a while' #18607 - then we can switch apiv4 address to call create & address the is_primary handling bypass

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@seamuslee001 are you able to look at this one? I have some follow on work but just want this merged first (ideally also #18607 )

[seamuslee001]

This was a bit trick for me to get my head around but seeing the other PR helped a bit but seems like unit tests should cover us here merging