(REF) Switch to composer-compile-lib #18646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a revision of a change made in the same dev-cycle (#18465). It externalizes some code and makes it easier to use the same techniques in an extension.
Before
civicrm-core
scssphp
,php-autoprefixer
, andcompile-plugin
Civi\Compile\Scss::build
.civicrm-core:ext/greenwich
Civi\Compile\Scss::build
After
civicrm-core
composer-compile-lib
) -- which in turn pulls in those otherscivicrm-core:ext/greenwich
CCL\Tasks::scss
Comments
There are a couple upshots of this change:
CCL\Tasks::scss
*.css
and a smaller*.min.css
scss-import-prefixes
, which makes it easier to stitch together files from diff placesSee also: https://github.com/civicrm/composer-compile-lib