[Ref] cleanup alterActionSchedule #21047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
We can simplify this function now as basicFields is keyed by the real field name and all pseudofields are already in basicFields.
eileenmcnaughton
force-pushed
the
tok_return
branch
from
bfce5d4
to
3fcf098
Compare
|
@colemanw also this has good cover in testTokenRendering |
seamuslee001
reviewed
Aug 7, 2021
| foreach (array_keys($this->getPseudoTokens()) as $token) { | ||
| $split = explode(':', $token); | ||
| $e->query->select('e.' . $fields[$split[0]]['name'] . ' AS ' . $this->getEntityAlias() . $split[0]); | ||
| foreach ($this->getReturnFields() as $token) { |
There was a problem hiding this comment.
@eileenmcnaughton what has happened to the pseudo tokens?
There was a problem hiding this comment.
@seamuslee001 yeah - it turned out I never needed them - (or perhaps I did before I got it sane) what I was doing was adding in the field they need - ie contribution_status_id - but since that field is ALSO in getReturnFields 'under it's own name' - I don't need the spy-version
There was a problem hiding this comment.
(the tests specifically cover these )
|
Tests should cover us here merging |
|
thanks @seamuslee001 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Ref] cleanup alterActionSchedule
Before
More code
After
Less ... but since I pre-added really solid testing on this function we can be sure that a green light means it wasn't missed
Technical Details
We can simplify this function now as basicFields is keyed by the real field name and
all pseudofields are already in basicFields.
tests in
testTokenRenderingcover both pseudo & non pseudo fieldsComments