Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2747 REF] Move all the generic functions to the parent #21057

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 7, 2021

Overview

[REF] Move all the generic functions to the parent

Before

Both entity specific & generic functions on the specific class

After

All generic functions moved to parent

Technical Details

This is for clarity, note that I need agreement on
https://lab.civicrm.org/dev/core/-/issues/2745
to decide whether to keep 'getExposedFields' or not - hence
that is not moved at this stage

Comments

@civibot
Copy link

civibot bot commented Aug 7, 2021

(Standard links)

@civibot civibot bot added the master label Aug 7, 2021
@eileenmcnaughton eileenmcnaughton changed the title [REF] Move all the generic functions to the parent dev/core#2747 REF] Move all the generic functions to the parent Aug 7, 2021
@eileenmcnaughton eileenmcnaughton force-pushed the tok_resolve branch 2 times, most recently from 6c59a95 to c5915a1 Compare August 7, 2021 05:14
This is for clarity, note that I need agreement on
https://lab.civicrm.org/dev/core/-/issues/2745
to decide whether to keep 'getExposedFields' or not - hence
that is not moved at this stage
@colemanw
Copy link
Member

colemanw commented Aug 9, 2021

OK, I see that the parent class currently only has one child.

@colemanw colemanw merged commit d4f779e into civicrm:master Aug 9, 2021
@eileenmcnaughton eileenmcnaughton deleted the tok_resolve branch August 9, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants