Remove unused assignment

[eileenmcnaughton]

Overview

Remove unused assignment

Before

A template assignment 'htmlContent' is done in the wrong place (formRule function) - a bit of a search shows that this is not used in any of the email or pdf classes that access the function

After

poof

Technical Details

I thought I'd finish decommissioning this old class & start to fix the pdf classes to use a trait like the email classes do - but when I looked at this function it seemed odd & on further digging I couldn't find a reason for the oddness - maybe @demeritcowboy can?

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I do remember something about saveTemplate and saveTemplateName coming up before, if that's what you mean. Will see if I can find.

[eileenmcnaughton]

@demeritcowboy my thinking is to move the save template rule to the main task form - since it's used by different tasks like email & pdf tasks - but I think this part is not needed

[demeritcowboy]

Ok yes on the htmlContent part it seems not needed. It looks like it was put into formRule as a way of dealing with the ckeditor contents disappearing when validation failed and the page reloaded, rightly or wrongly:
civicrm/civicrm-svn@90726cd

That's obviously handled differently now and testing it the ckeditor contents show up on page reload after validation fail.

[eileenmcnaughton]

thanks @demeritcowboy !