APIv4 - Support multiple implicit joins to the same table #21071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
force-pushed
the
api4JoinFixes
branch
2 times, most recently
from
bb2678e
to
af57f65
Compare
colemanw
changed the title
colemanw
force-pushed
the
api4JoinFixes
branch
from
94074f9
to
93163f7
Compare
colemanw
force-pushed
the
api4JoinFixes
branch
2 times, most recently
from
fcbd12a
to
1d748e1
Compare
|
It'll be a couple days before I can do a proper review, but I reviewed the test and can confirm that it's correct. |
Before: APIv4 always used the name of the table when adding an implicit join, meaning it could only be added once. After: Creates a unique alias for each instance of an implicit join, allowing the same table to be joined multiple times. Fixes dev/report#73
colemanw
force-pushed
the
api4JoinFixes
branch
from
1d748e1
to
19eacca
Compare
|
My manual testing shows that this fixes the original issue without any side effects I can see (which would get picked up in tests anyway I guess). |
|
Merging based on @MegaphoneJon 's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Supports multiple implicit joins to the same table in APIv4 & SearchKit.
Fixes https://lab.civicrm.org/dev/report/-/issues/73
Before
APIv4 always used the name of the table with no sql alias when adding an implicit join, meaning it could only be added once.
After
Creates a unique alias for each instance of an implicit join, allowing the same table to be joined multiple times.