Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade angular-file-uploader to v2.6.1 #21081

Merged

Conversation

colemanw
Copy link
Member

Overview

Upgrades an Angular plugin that is only used by the CiviCase extension, in preparation for also using it in Afform.

Before

AngularFileUploader v1.1.6

After

AngularFileUploader v2.6.1

Technical Details

I couldn't find any release notes about breaking changes, and I tested the CiviCase extension and the drag-n-drop file uploads work fine before and after.

image

@civibot
Copy link

civibot bot commented Aug 10, 2021

(Standard links)

@civibot civibot bot added the master label Aug 10, 2021
@totten
Copy link
Member

totten commented Aug 10, 2021

@colemanw This seems look a good idea. FWIW, I grepped universe and couldn't find any consumers besides CiviCase and crmAttachment / crm-attachments. For crmAttachment, I did an r-run on the autobuild site (via "Mailings => New Mailing =>Attachments"), and that seemed ok.

@totten
Copy link
Member

totten commented Aug 10, 2021

Not sure what to make of the r-test failures though.

@seamuslee001
Copy link
Contributor

I think the test problem is this line hasn't been altered https://github.com/civicrm/civicrm-core/blob/master/karma.conf.js#L39

@colemanw
Copy link
Member Author

That's it, thanks @seamuslee001

@totten
Copy link
Member

totten commented Aug 11, 2021

@colemanw Merge conflict on composer.lock. Otherwise MOP

@eileenmcnaughton eileenmcnaughton merged commit 43a25f5 into civicrm:master Aug 11, 2021
@eileenmcnaughton eileenmcnaughton deleted the upgradeAngularFileUploader branch August 11, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants