Fix caching on campaign pseudoconstant

[eileenmcnaughton]

Overview

Fix caching on campaign pseudoconstant

Before

static

After

Civi::statics

Technical Details

tests like it better - pulled out of the token PRs

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton checkstyle failed, and not just because of the poor grammar in "isCampaignEnable"

[eileenmcnaughton]

@colemanw you can't mess with history

[eileenmcnaughton]

@colemanw passed now

[colemanw]

Sorry @eileenmcnaughton I just read this code and actually paid attention, and now it occurs to me to ask: "what could possibly be the benefit of caching the results of in_array()?" I can think of none. I think this whole function should be reduced to 1 line.

[eileenmcnaughton]

@colemanw I think you're right!