Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2774 : Sort by date column on multirecord field listing section on profile edit mode doesn't work #21191

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

monishdeb
Copy link
Member

Overview

  1. create a multi-record custom data set for contacts
  2. create a date field of format mm/dd/yyyy. it may be beneficial to create another text field for reference.
  3. Configure a profile using those multi-record custom data field
  4. Go to profile edit mode and add some data to a contact record. For the date field, select some values across multiple years.
  5. Try sorting by the date on the frontend profile form in edit mode

Before

before

After

after

Comments

ping @lcdservices @seamuslee001 @eileenmcnaughton

@civibot
Copy link

civibot bot commented Aug 20, 2021

(Standard links)

@civibot civibot bot added the master label Aug 20, 2021
@lcdservices
Copy link
Contributor

Tested and this works as intended.

@eileenmcnaughton
Copy link
Contributor

I think the r-run testing @lcdservices has done is appropriate to this change (I can't see a meaningful way to add a unit test )

@seamuslee001
Copy link
Contributor

Merging as per @lcdservices @eileenmcnaughton 's comment

@seamuslee001 seamuslee001 merged commit ef6143c into civicrm:master Aug 22, 2021
@seamuslee001 seamuslee001 deleted the dev_2774 branch August 22, 2021 23:43
@monishdeb
Copy link
Member Author

Thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants